Multiple ogre + OSX #5

Tobias-Fischer · 2021-03-23T22:08:54Z

Checklist

Used a personal fork of the feedstock to propose changes
Bumped the build number (if the version is unchanged)
Reset the build number to 0 (if the version changed)
Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
Ensured the license file is being packaged.

conda-forge-linter · 2021-03-23T22:08:58Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Tobias-Fischer · 2021-03-23T22:09:01Z

Follow-up on conda-forge/libignition-rendering4-feedstock#8

Tobias-Fischer · 2021-03-23T22:09:14Z

@conda-forge-admin, please rerender

…da-forge-pinning 2021.03.23.17.55.38

Tobias-Fischer · 2021-03-23T22:26:46Z

@conda-forge-admin, please rerender

github-actions · 2021-03-23T22:27:43Z

Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you, but it looks like there was nothing to do.

Tobias-Fischer · 2021-03-23T22:38:51Z

@conda-forge-admin, please rerender

…da-forge-pinning 2021.03.23.17.55.38

Tobias-Fischer · 2021-03-23T22:41:20Z

Hey @traversaro - note that the conda_build_config had the wrong suffix (yml instead of yaml) and thus wasn't picked up (i.e. not the macos stuff either). Could be relevant for the osx builds.

traversaro · 2021-03-23T22:42:36Z

Hey @traversaro - note that the conda_build_config had the wrong suffix (yml instead of yaml) and thus wasn't picked up (i.e. not the macos stuff either). Could be relevant for the osx builds.

Yes, I noticed and fixed as well in the other PRs, sorry for not highlighting it.

Tobias-Fischer · 2021-03-24T00:50:23Z

On ogre 1.10 sth pulls in libarchive - I tried adding it to the host deps but still the system one is found:

21/32 Test #21: INTEGRATION_thermal_camera_plugin ...........Subprocess aborted***Exception:   0.25 sec
dyld: Symbol not found: _iconv
  Referenced from: /usr/lib/libarchive.2.dylib
  Expected in: $PREFIX/lib/libiconv.2.dylib
 in /usr/lib/libarchive.2.dylib

I think they are exactly the same tests that fail for ogre 1.12, there with

dyld: Library not loaded: /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libBLAS.dylib
  Referenced from: /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/vecLib
  Reason: Incompatible library version: vecLib requires version 1.0.0 or later, but libBLAS.dylib provides version 0.0.0

traversaro · 2021-03-24T10:24:46Z

Interesting, so both ogre 1.10 and 1.12 do not work correctly when running the tests during conda-build. On the other hand, as far I understand (for 1.12 from #3 (comment), for 1.10 because people actually use Gazebo on macOS) it seems that on most users setup ogre for some reason works. I wonder if this means that we should skip the test on macOS for now, open an issue to track this but for the time being enabling the macOS builds for both ogre 1.10 and 1.12 .

wolfv · 2021-03-24T14:32:02Z

Hmm. When I tried locally, I could execute the unit test fine when changing the directory to be in the same directory as the exectuable.

E.g.

cd test; ./UNIT_Lidar_test

was running fine, while ctest ... had the same issues as in the tests above.

A wild guess in the dark could be that this might be fixed by setting some rpath related cmake variables. :)

Tobias-Fischer · 2021-03-24T21:21:04Z

@wolfv - was that the case for both the ogre1.10 and ogre1.12 builds?

wolfv · 2021-03-24T21:27:20Z

I only tested 1.12

Tobias-Fischer · 2021-03-24T23:00:45Z

Alright, that's even better as the test error there seems "more severe". @traversaro would you be happy to look into the rpath stuff? You're probably ten times faster than what I'd be.

traversaro · 2021-03-24T23:04:12Z

I'll try. I just realized that I can actually get a test macOS machine at work, I will try to use it for this debug.

Tobias-Fischer · 2021-03-25T21:42:57Z

So setting DYLD_LIBRARY_PATH or DYLD_FALLBACK_LIBRARY_PATH as suggested by @wolfv on gitter didn't fix the tests .. :(

Tobias-Fischer · 2021-03-25T21:43:43Z

Two options I guess: Disabling the failing tests for now and open an issue, or digging deeper (including RPATH etc). What do you think @traversaro @wolfv?

Tobias-Fischer · 2021-03-30T05:19:14Z

Quick reminder @traversaro @wolfv

traversaro · 2021-03-30T05:25:32Z

Quick reminder @traversaro @wolfv

I will get access to a real mac today. I will check if a basic example is able to start, and if yes I would merge, otherwise I would wait.

Tobias-Fischer · 2021-04-08T02:49:36Z

Hi @traversaro - did you have a chance to check this on a physical mac?

traversaro · 2021-04-08T05:48:59Z

Sorry, still on the backlog, but on the top of it!

conda-forge-linter · 2021-05-13T02:17:30Z

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

conda-forge-linter · 2021-05-13T02:18:21Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Tobias-Fischer · 2021-05-13T02:18:51Z

@conda-forge-admin, please rerender

…nda-forge-pinning 2021.05.12.18.50.42

traversaro · 2021-10-07T15:09:47Z

I am finally back on it. I don't think anything that used ignition-rendering-ogre on macOS was working back in time due to gazebosim/gz-rendering#454 . However, I think we may probably have the same tests problem we have in conda-forge/libignition-rendering4-feedstock#19 (comment) . So, I think we can revive this PR, supress any test failure we may have, and then check if the tests of the fortress version work fine (we can also fix older version if there is interest, but I would start by getting the Fortress version to work). What do you think @Tobias-Fischer ?

traversaro · 2021-10-07T15:10:04Z

@conda-forge-admin, please rerender

…a-forge-pinning 2021.10.07.13.38.58

conda-forge-linter · 2021-10-07T15:12:05Z

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

conda-forge-linter · 2021-10-07T15:42:48Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

traversaro · 2021-10-07T15:43:09Z

@conda-forge-admin, please rerender

…a-forge-pinning 2021.10.07.13.38.58

traversaro · 2021-10-07T15:55:22Z

Actually, we can also continue to skip osx for now, and then enable as part or after #16 . The important thing that I prefer is to merge this one before #16 .

Tobias-Fischer · 2021-10-07T23:55:38Z

I'd be happy for this one to be merged in.

Tobias-Fischer · 2021-10-08T05:46:17Z

recipe/meta.yaml

  run:
    - __osx >={{ MACOSX_DEPLOYMENT_TARGET|default("10.9") }}  # [osx and x86_64]
+    - {{ pin_compatible('ogre', max_pin='x.x') }}


This should not be needed actually.

https://github.com/conda-forge/ogre-feedstock/blob/6a69a77b79acce745d2bc6fd3d6656dfc1ed0dc3/recipe/meta.yaml#L21-L22

That is true for the latest version of ogre, but note that here we link a bit old versions such as 1.10 or 1.12, the run_exports are set correctly also there?

Yes, the latest 1.10 build has it as well: https://github.com/conda-forge/ogre-feedstock/blob/5235a903689d335447e76f1397d62afd4b9b7dda/recipe/meta.yaml#L19

Great, let's remove it then.

Tobias-Fischer added 2 commits March 24, 2021 08:00

Build for multiple ogre

775ecaa

Bump build num and multiple ogre and build osx

184fb78

Tobias-Fischer requested review from j-rivero, traversaro and wolfv as code owners March 23, 2021 22:08

conda-forge-linter and others added 2 commits March 23, 2021 22:10

MNT: Re-rendered with conda-build 3.21.4, conda-smithy 3.9.0, and con…

34e256d

…da-forge-pinning 2021.03.23.17.55.38

Update meta.yaml

e76313a

Rename conda_build_config.yml to conda_build_config.yaml

c3844cc

MNT: Re-rendered with conda-build 3.21.4, conda-smithy 3.9.0, and con…

d250a87

…da-forge-pinning 2021.03.23.17.55.38

Tobias-Fischer changed the title ~~Multiple ogre~~ Multiple ogre + OSX Mar 23, 2021

Update meta.yaml

0d40998

Tobias-Fischer added 2 commits March 25, 2021 20:26

Try fix OSX tests

79a99ca

Update build.sh

d9b5e26

Tobias-Fischer mentioned this pull request Mar 30, 2021

Fix macOS build #3

Closed

5 tasks

Update build.sh

382159e

Merge branch 'master' into multiple-ogre

c0c4ec2

conda-forge-linter and others added 2 commits May 13, 2021 02:19

MNT: Re-rendered with conda-build 3.21.4, conda-smithy 3.10.1, and co…

6eb4aca

…nda-forge-pinning 2021.05.12.18.50.42

Update build.sh

d65214d

Tobias-Fischer mentioned this pull request Jun 13, 2021

Add OSX build conda-forge/libignition-gazebo-feedstock#2

Closed

Tobias-Fischer mentioned this pull request Sep 26, 2021

ARM OSX Migrator #15

Closed

MNT: Re-rendered with conda-build 3.21.4, conda-smithy 3.12, and cond…

e3deb91

…a-forge-pinning 2021.10.07.13.38.58

Merge branch 'master' into multiple-ogre

d5ab59b

traversaro approved these changes Oct 7, 2021

View reviewed changes

MNT: Re-rendered with conda-build 3.21.4, conda-smithy 3.12, and cond…

f35bdcb

…a-forge-pinning 2021.10.07.13.38.58

Skip failing tests on osx

db2d525

Tobias-Fischer commented Oct 8, 2021

View reviewed changes

Update meta.yaml

b23b59d

traversaro merged commit c4600b5 into conda-forge:master Oct 8, 2021

Tobias-Fischer deleted the multiple-ogre branch October 10, 2021 21:18

Multiple ogre + OSX #5

Multiple ogre + OSX #5

Conversation

Tobias-Fischer commented Mar 23, 2021 • edited Loading

conda-forge-linter commented Mar 23, 2021

Tobias-Fischer commented Mar 23, 2021

Tobias-Fischer commented Mar 23, 2021

Tobias-Fischer commented Mar 23, 2021

github-actions bot commented Mar 23, 2021

Tobias-Fischer commented Mar 23, 2021

Tobias-Fischer commented Mar 23, 2021

traversaro commented Mar 23, 2021

Tobias-Fischer commented Mar 24, 2021

traversaro commented Mar 24, 2021

wolfv commented Mar 24, 2021

Tobias-Fischer commented Mar 24, 2021

wolfv commented Mar 24, 2021

Tobias-Fischer commented Mar 24, 2021

traversaro commented Mar 24, 2021

Tobias-Fischer commented Mar 25, 2021

Tobias-Fischer commented Mar 25, 2021

Tobias-Fischer commented Mar 30, 2021

traversaro commented Mar 30, 2021

Tobias-Fischer commented Apr 8, 2021

traversaro commented Apr 8, 2021

conda-forge-linter commented May 13, 2021

conda-forge-linter commented May 13, 2021

Tobias-Fischer commented May 13, 2021

traversaro commented Oct 7, 2021

traversaro commented Oct 7, 2021

conda-forge-linter commented Oct 7, 2021

conda-forge-linter commented Oct 7, 2021

traversaro commented Oct 7, 2021

traversaro commented Oct 7, 2021

Tobias-Fischer commented Oct 7, 2021

Tobias-Fischer Oct 8, 2021

Choose a reason for hiding this comment

Tobias-Fischer Oct 8, 2021

Choose a reason for hiding this comment

traversaro Oct 8, 2021

Choose a reason for hiding this comment

Tobias-Fischer Oct 8, 2021

Choose a reason for hiding this comment

traversaro Oct 8, 2021

Choose a reason for hiding this comment

Tobias-Fischer commented Mar 23, 2021 •

edited

Loading